View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005154 | Kali Linux | [All Projects] Kali Package Improvement | public | 2018-12-13 01:22 | 2019-05-21 13:40 |
Reporter | radualexandrupopescu | Assigned To | sbrun | ||
Priority | normal | Severity | tweak | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | kali-dev | ||||
Target Version | Fixed in Version | ||||
Summary | 0005154: smbmap launch script causes files to be downloaded in wrong directory | ||||
Description | The script that actually launches smbmap.py (the one from [packages/smbmap.git] / debian / helper-script / smbmap) first changes directory to "/usr/share/smbmap" and than calls the smbmap.py script. This has adverse effects when using the "--download" flag (https://github.com/ShawnDEvans/smbmap/blob/master/smbmap.py#L802) because the function (download_file https://github.com/ShawnDEvans/smbmap/blob/master/smbmap.py#L635) actually uses "os.getcwd" (https://github.com/ShawnDEvans/smbmap/blob/master/smbmap.py#L642) to create the download file; this results in the downloaded file landing somewhere in "/usr/share/smbmap". One quick fix would be to drop the "cd" part and just use 'python /usr/share/smbmap/smbmap.py "$@"'. Another way would be just to sim-link '/usr/share/smbmap/smbmap.py' in '/usr/bin/smbmap', as the py file is already marked as executable. | ||||
Steps To Reproduce | 1. Change to a working directory cd /root/tests/smbmap 2. Download a file using smbmap smbmap -u myuser -p mypass -d workgroup -H DESKTOP-HELPDESK --download 'C$\\temp\\passwords.txt' 3. Observe the file missing from /root/tests/smbmap 4. Locate the file in /usr/share/smbmap/ | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2018-12-13 01:22 | radualexandrupopescu | New Issue | |
2019-05-21 13:40 | sbrun | Assigned To | => sbrun |
2019-05-21 13:40 | sbrun | Status | new => resolved |
2019-05-21 13:40 | sbrun | Resolution | open => fixed |
2019-05-21 13:40 | sbrun | Note Added: 0010598 |